Simple Asset Loop out #872
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
force-pushed
the
asset_simple_loopout
branch
from
5e35488 to
fd87cb9
Compare
ultimate deliverable for asset specification will need to be specification by group_key, rather that asset_id only |
bhandras
reviewed
Jan 9, 2025
| *lndclient.PaymentStatus, error) { | ||
|
|
||
| // If we want to use an asset for the payment, we need to use the asset | ||
| // client. | ||
| if useAsset { |
There was a problem hiding this comment.
I think we could just check if assetID is not nil here.
sputn1ck
force-pushed
the
asset_simple_loopout
branch
from
fd87cb9 to
af8256f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple asset loop out. Clients are able to specify a
asset_idduring the normal loop out operation. If an asset is provided, the loop client will try to pay the swap invoice with the connected taproot-assets daemon.